Feature/eebus rebased #1561
Feature/eebus rebased #1561
Conversation
mlitre
requested review from
Pietfried,
SebaLukas,
a-w50,
andistorm,
corneliusclaussen,
djchhp,
hikinggrass and
james-ctc
as code owners
andistorm
left a comment
andistorm
left a comment
There was a problem hiding this comment.
LGTM in general 🐧
The documentation is very helpful
I marked a couple of things that shouldn't be forget before merging
.ci/build-kit/docker/Dockerfile
Outdated
| # Can be used to use an other version of everest-cmake | ||
| ADD "https://www.random.org/cgi-bin/randbyte?nbytes=10&format=h" skipcache | ||
| ENV EVEREST_CMAKE_PATH=/usr/lib/cmake/everest-cmake | ||
| ENV EVEREST_CMAKE_VERSION=tmp/eebus | ||
| RUN rm -rf ${EVEREST_CMAKE_PATH} \ | ||
| && git clone https://github.com/EVerest/everest-cmake.git ${EVEREST_CMAKE_PATH} \ | ||
| && cd ${EVEREST_CMAKE_PATH} \ | ||
| && git checkout ${EVEREST_CMAKE_VERSION} \ | ||
| && rm -r .git |
There was a problem hiding this comment.
Would be good to move most of it in the ghcr.io/everest/everest-ci/build-env-base image before merging,
Which means opening a PR in everest-ci, merge it, tag a new version/release, use this tag in the ci workflow
| fi | ||
|
|
||
| pip install --break-system-packages \ | ||
| python3 -m pip install --break-system-packages \ |
There was a problem hiding this comment.
Could be in a dedicated PR "Improce CI scripts" or so, but not required from my side
| fi | ||
|
|
||
| pip install --break-system-packages -r tests/ocpp_tests/requirements.txt | ||
| python3 -m pip install --break-system-packages -r tests/ocpp_tests/requirements.txt |
There was a problem hiding this comment.
Could be in a dedicated PR "Improce CI scripts" or so, but not required from my side
|
|
||
| cd tests | ||
| pytest \ | ||
| python3 -m pytest \ |
There was a problem hiding this comment.
Could be in a dedicated PR "Improce CI scripts" or so, but not required from my side
This is the first implementation of EEBus and the LPC use case. The EEBUS module requires an energy sink to limit the energy flow request going to the energy manager. Signed-off-by: Andreas Heinrich <[email protected]> Signed-off-by: Martin Litre <[email protected]>
Signed-off-by: Martin Litre <[email protected]>
Co-authored-by: Andreas Heinrich <[email protected]> Signed-off-by: Martin Litre <[email protected]>
Signed-off-by: Martin Litre <[email protected]>
mlitre
force-pushed
the
feature/eebus-rebased
branch
from
09464f8 to
d1574fe
Compare
Describe your changes
Issue ticket number and link
Checklist before requesting a review